Post new topic Post a reply  [ 8 posts ] 
Author Message
 Post subject: 2019-02-06's bug
PostPosted: Wed Feb 06, 2019 7:37 am 
Offline
Site Admin
User avatar

Joined: Wed Apr 08, 2015 5:56 pm
Posts: 782
A bug seemed to happen a few minutes ago, as Imperial reinforcements arrived in Amritsar.
It's time to go to work so I will be able to investigate only this evening... sorry

Since something wrong happened, time is sort of suspended, so no ship should be destroyed, and no fleet can move


Top
 Profile  
 

 Post subject: Re: Bug
PostPosted: Wed Feb 06, 2019 11:58 am 
Offline
Site Admin
User avatar

Joined: Wed Apr 08, 2015 5:56 pm
Posts: 782
It's lunch time for me and I have a few minutes to investigate.

It seems that, with the actual code, the battle is just to big for the server to run it correctly.
So it's a scaling issue, not the most easy to handle...


Top
 Profile  
 

 Post subject: Re: Bug
PostPosted: Wed Feb 06, 2019 6:49 pm 
Offline
Site Admin
User avatar

Joined: Wed Apr 08, 2015 5:56 pm
Posts: 782
The situation has been resumed (almost...), but the issue is not fixed: it will probably happen again if a new fleet joins the battle, or maybe in other cases too.


Top
 Profile  
 

 Post subject: Re: Bug
PostPosted: Wed Feb 06, 2019 8:22 pm 
Offline
Site Admin
User avatar

Joined: Wed Apr 08, 2015 5:56 pm
Posts: 782
I tried a fix, we'll see if it works if another fleet joins the battle!


Top
 Profile  
 

 Post subject: Re: Bug
PostPosted: Thu Feb 07, 2019 6:14 pm 
Offline
Site Admin
User avatar

Joined: Wed Apr 08, 2015 5:56 pm
Posts: 782
The fix seems to work!

Just for your information, if ever someone is interested: each time a new fleet joins a battle, there was a portion of code doing one big operation for all the ship engaged in the battle. Obviously, 40,000 ships for one operation was too much.
So I split this big operation in several smaller (one for each slice of 10,000 ships), and it seems to have solved the issue.


Top
 Profile  
 

 Post subject: Re: 2019-02-06's bug
PostPosted: Sun Feb 17, 2019 1:43 am 
Offline
User avatar

Joined: Tue Jan 05, 2016 11:29 pm
Posts: 239
Late, but thank you for finding a workaround! :) This battle certainly is enormous.

_________________
Icon by LyrykenLied @ DA


Top
 Profile  
 

 Post subject: Re: 2019-02-06's bug
PostPosted: Tue Feb 26, 2019 4:42 pm 
Offline
Site Admin
User avatar

Joined: Wed Apr 08, 2015 5:56 pm
Posts: 782
Another bug revealed by the gigantic proportions of this 14th battle of Amritsar: stats are wrong
http://chronicles.kosmosinsel.net/tun.php?id=449
Attachment:
kc20190226.png
kc20190226.png [ 380.02 KiB | Viewed 579 times ]


There are 2 problems:
- the number of engaged ships should not be less that the number of lost ships (this has probably been caused by the bug at the beginning of the battle)
- this "16777215" number is more than suspicious; this is indeed the max value of the "mediumint" data type in MySQL; so the real number has exceeded the maximum capacity, I have to change it for a bigger integer data type.
https://dev.mysql.com/doc/refman/5.7/en ... types.html


Top
 Profile  
 

 Post subject: Re: 2019-02-06's bug
PostPosted: Sun Mar 03, 2019 12:41 pm 
Offline
Site Admin
User avatar

Joined: Wed Apr 08, 2015 5:56 pm
Posts: 782
Stats have been manually (and carefully) corrected :)
http://chronicles.kosmosinsel.net/tun.php?id=449


Top
 Profile  
 

Display posts from previous:  Sort by  
Post new topic Post a reply  [ 8 posts ] 


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Theme created by Matti from Free Premium phpBB3 themes
Powered by phpBB® Forum Software © phpBB Group